This repository was archived by the owner on Dec 6, 2024. It is now read-only.
[2021-04-16] - CRDs are created with api-approved annotation, but did not complete API review #38
Comments
liggitt
changed the title
|
Thanks for the heads up @liggitt I am opening a PR shortly to resolve this! |
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this issue
May 29, 2024
…ment-doc Add deployment documentation
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this issue
Jun 6, 2024
…ment-doc Add deployment documentation
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this issue
Jun 14, 2024
…t-kep Update the code with latest KEP
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
https://github.com/kubernetes-sigs/container-object-storage-interface-api/blob/master/kustomization.yaml#L10 adds an api-approved annotation to all loaded CRDs
The APIs in question have not actually been approved via the k8s API review process
Additionally, using a mixin to automatically add the annotation to all CRDs is not appropriate... it confers approval status on any newly introduced CRDs or updates to CRD manifests without actual review / approve.
As noted in https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/2337-k8s.io-group-protection/README.md#proposal, until the API is approved, a string starting with
unapprovedcan be used as a placeholdercc @thockin
The text was updated successfully, but these errors were encountered: