Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

syncer: check meta equality for sa type token secret #83

Merged
merged 1 commit into from
Jun 1, 2021
Merged

syncer: check meta equality for sa type token secret #83

merged 1 commit into from
Jun 1, 2021

Conversation

zhuangqh
Copy link
Contributor

Signed-off-by: zhuangqh [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhuangqh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2021
Fei-Guo
Fei-Guo reviewed May 31, 2021
View reviewed changes
virtualcluster/pkg/syncer/conversion/equality.go
updatedObj = pObj.DeepCopy()
}
updatedObj.Annotations = annotations
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 537, should we return nil or updatedObj?

@zhuangqh
Copy link
Contributor Author

zhuangqh commented Jun 1, 2021

/test pull-cluster-api-provider-nested-test

@k8s-ci-robot
Copy link
Contributor

@zhuangqh: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-provider-nested-test e2052f8 link /test pull-cluster-api-provider-nested-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Fei-Guo Fei-Guo merged commit 5985978 into kubernetes-retired:main Jun 1, 2021
@Fei-Guo
Copy link

Fei-Guo commented Jun 1, 2021

/lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fei-Guo Fei-Guo Fei-Guo left review comments

@charleszheng44 charleszheng44 Awaiting requested review from charleszheng44

@christopherhein christopherhein Awaiting requested review from christopherhein

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhuangqh @k8s-ci-robot @Fei-Guo