Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Setting kind name as CAPN #72

Merged
merged 1 commit into from
May 23, 2021
Merged

Conversation

gyliu513
Copy link
Contributor

Sometimes people want to run multiple kind clusters to have different test purpose, it is better to add a name for the kind cluster for capn as well.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2021
@Fei-Guo
Copy link

Fei-Guo commented May 22, 2021

Thanks for the fix.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 22, 2021
@christopherhein
Copy link
Contributor

@gyliu513 looks like you need to rebase. I'm wondering if this is necessary? Since if a person is already running a kind they should know this and would have the sense to add the --name flag. 🤔

Either way we should probably add a Cleanup section to this doc that does kind delete cluster --name capn.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2021
@christopherhein
Copy link
Contributor

Thanks for adding this! 🎉

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, gyliu513

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4e7f7df into kubernetes-retired:main May 23, 2021
@gyliu513 gyliu513 deleted the kind branch May 24, 2021 01:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants