Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Implement the NestedEtcd controller #30

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Implement the NestedEtcd controller #30

merged 1 commit into from
Mar 18, 2021

Conversation

charleszheng44
Copy link
Contributor

@charleszheng44 charleszheng44 commented Jan 30, 2021 •
edited
Loading

This PR implements the NestedEtcd controller.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2021
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 30, 2021
@charleszheng44 charleszheng44 force-pushed the feature/nestedetcd-controller branch from a64b4b8 to a89320b Compare February 1, 2021 18:43
christopherhein
christopherhein reviewed Feb 2, 2021
View reviewed changes
Copy link
Contributor

@christopherhein christopherhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good so far, nice work @charleszheng44. Do you want to talk about what you've run into today on the CAPN call?

@christopherhein christopherhein mentioned this pull request Feb 2, 2021
Merged
@charleszheng44
Copy link
Contributor Author

This looks really good so far, nice work @charleszheng44. Do you want to talk about what you've run into today on the CAPN call?

Yes. We can talk about this PR in today's meeting.

christopherhein
christopherhein reviewed Feb 16, 2021
View reviewed changes
Copy link
Contributor

@christopherhein christopherhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions but otherwise looks good.

@charleszheng44 charleszheng44 force-pushed the feature/nestedetcd-controller branch 3 times, most recently from 55e7ff4 to 3d78676 Compare March 10, 2021 23:11
@charleszheng44 charleszheng44 changed the title [WIP] implement the NestedEtcd controller Implement the NestedEtcd controller Mar 10, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2021
christopherhein
christopherhein reviewed Mar 12, 2021
View reviewed changes
Copy link
Contributor

@christopherhein christopherhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only a couple comments, questions.

@christopherhein
Copy link
Contributor

We also probably want tests for this.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2021
@charleszheng44 charleszheng44 force-pushed the feature/nestedetcd-controller branch from 3d78676 to 87af423 Compare March 15, 2021 06:22
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2021
@charleszheng44 charleszheng44 force-pushed the feature/nestedetcd-controller branch from 87af423 to ba6e889 Compare March 17, 2021 21:03
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 17, 2021
@charleszheng44
Copy link
Contributor Author

We also probably want tests for this.

test cases added

christopherhein
christopherhein approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@christopherhein christopherhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think we can merge this and keep working on the next few controllers and we can always tweak implementation more as we go.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleszheng44, christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1d6af6a into kubernetes-retired:master Mar 18, 2021
@charleszheng44 charleszheng44 mentioned this pull request Jun 3, 2021
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherhein christopherhein christopherhein approved these changes

@davidewatson davidewatson Awaiting requested review from davidewatson

Assignees

@christopherhein christopherhein

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charleszheng44 @christopherhein @k8s-ci-robot