This repository was archived by the owner on Oct 28, 2024. It is now read-only.
Remove old webhookconfiguration if it alreasy exist before create new one #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In #145 , we use self-signed certificate for
ValidatingWebhookConfiguration
, that's means we will generate self-signed CA whenvc-manager
startup.Based on current implements, when creating
ValidatingWebhookConfiguration
and found it already exist we will give up to create a new one and expect to use the older one, that's will cause problem since theprivate key
is re-generated by new CA but in oldValidatingWebhookConfiguration
included the oldCA
, that's will case the webhook raise:In my env, the
vc-manager
has restarted by unknown reason, then I hit the error mentioned upper.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #