Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

🐛 Add ReadHeaderTimeout values #291

Closed
m-messiah opened this issue Jul 20, 2022 · 1 comment · Fixed by #292
Closed

🐛 Add ReadHeaderTimeout values #291

m-messiah opened this issue Jul 20, 2022 · 1 comment · Fixed by #292
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@m-messiah
Copy link
Contributor

What steps did you take and what happened:
[A clear and concise description on how to REPRODUCE the bug.]
The following lint errors started showing up after the latest upgrade to golangci-lint (v1.47.1):

cmd/vn-agent/app/server.go:100:8: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
        s := &http.Server{
                Addr:    fmt.Sprintf(":%d", serverOption.Port),
                Handler: handler,
                TLSConfig: &tls.Config{
                        ClientAuth: tls.RequestClientCert,
                        MinVersion: tls.VersionTLS12,
                },
        }

/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api-provider-nested/labels?q=area for the list of labels]

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 20, 2022
@christopherhein
Copy link
Contributor

Thanks for catching this, I wonder if we should consider upgrading to 1.47.1 golangci-lint and then make sure we resolve this in that addition?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants