-
Notifications
You must be signed in to change notification settings - Fork 65
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
README.md
Outdated
@@ -1,3 +1,8 @@ | |||
# ⚠️ This code has moved | |||
|
|||
This repo is only accepting bug fixes for the code that exists here. All new development is being done in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make this even bigger ##
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bigger is fine with me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
README.md
Outdated
@@ -1,3 +1,8 @@ | |||
# ⚠️ This code has moved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this say for the next version / future development?
@vincepri can u ptal |
README.md
Outdated
@@ -1,3 +1,7 @@ | |||
# ⚠️ Legacy repository. Current code has moved | |||
|
|||
## This repository is only accepting bug fixes for. All new development is being done in the [cluster-api](https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm) repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg accidentally a word
Signed-off-by: Chuck Ha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
Signed-off-by: Chuck Ha [email protected]
What this PR does / why we need it:
This PR informs users this is not an active repo and the code has moved.
/assign @ncdc
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #281