Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

🏃Update module dependencies #269

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

vincepri
Copy link
Contributor

@vincepri vincepri commented Oct 4, 2019

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2019
@k8s-ci-robot k8s-ci-robot requested review from chuckha and ncdc October 4, 2019 16:07
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2019
@vincepri
Copy link
Contributor Author

vincepri commented Oct 4, 2019

Related to kubernetes-sigs/cluster-api-provider-aws#1120 (comment)

@chuckha
Copy link
Contributor

chuckha commented Oct 4, 2019

/assign

@detiber
Copy link
Contributor

detiber commented Oct 4, 2019

/lgtm
/hold
hold for @chuckha's review

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Oct 4, 2019
@vincepri
Copy link
Contributor Author

vincepri commented Oct 4, 2019

@vincepri
Copy link
Contributor Author

vincepri commented Oct 4, 2019

Hold on, there is another repo (CAPI) that imports the different version of autorest

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2019
@vincepri vincepri changed the title 🏃Update module dependencies / fix Azure/go-autorest 🏃Update module dependencies Oct 4, 2019
@chuckha
Copy link
Contributor

chuckha commented Oct 4, 2019

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit eb4a7c8 into kubernetes-retired:master Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants