This repository was archived by the owner on Jul 30, 2021. It is now read-only.
🐛 Separate certificate logic for joins #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
ncdc
reviewed
Oct 2, 2019
ncdc
reviewed
Oct 2, 2019
With the introduction of support for external etcd comes better certificate management. This commit separates the worker join certificate logic from the control plane join certificate logic. Signed-off-by: Chuck Ha <[email protected]>
chuckha
force-pushed
the
control-plane-join-certs
branch
from
57f54d0 to
3aceccd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of support for external etcd comes better
certificate management. This commit separates the worker join certificate
logic from the control plane join certificate logic.
Signed-off-by: Chuck Ha [email protected]
What this PR does / why we need it:
This PR fixes the bug where control-planes could not join a cluster but were still provisioned.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #262
/cc @vincepri