🏃Align Makefile with other CAP* repos #257
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold until #256 merges |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
size/L
Makefile
Outdated
| ## -------------------------------------- | ||
|
|
||
| .PHONY: run | ||
| run: generate fmt vet ## Run against the configured Kubernetes cluster in ~/.kube/config |
There was a problem hiding this comment.
it looks like fmt and vet get removed in this change but are now referenced here
There was a problem hiding this comment.
Yeah those are part of golint, I'll remove these
There was a problem hiding this comment.
these were gone but they look to be back?
|
/lgtm |
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
makefile-like-others
branch
from
0ec5b24 to
304791e
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
/hold looks like fmt and vet snuck back in but they are still deleted? |
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Vince Prignano <[email protected]>
|
/hold cancel |
k8s-ci-robot
added
lgtm
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #