This repository was archived by the owner on Jul 30, 2021. It is now read-only.
🎉 Promote @sataqiu to a maintainer #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Chuck Ha <[email protected]>
chuckha
force-pushed
the
promote-sataqiu
branch
from
b3f399a to
71af19a
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
+1 from me |
|
+1 |
|
/hold cancel thanks for all your contributions @SataQiu ! |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chuck Ha [email protected]
What this PR does / why we need it:
@SataQiu has been an excellent reviewer and contributor to the project. I would like to promote him to a maintainer moving forward.
This will have a 1 week lazy consensus.
/hold