Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

✨ Add prow image building #239

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

vincepri
Copy link
Contributor

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2019
@vincepri
Copy link
Contributor Author

/assign @ncdc

@vincepri vincepri force-pushed the release-goodies branch 2 times, most recently from ea00015 to dc4f078 Compare September 19, 2019 20:32
@vincepri
Copy link
Contributor Author

Waiting for kubernetes/test-infra#14413 to merge

@vincepri
Copy link
Contributor Author

/assign @detiber

Copy link
Contributor

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about the release binary referenced in the Makefile, otherwise lgtm

Signed-off-by: Vince Prignano <[email protected]>
@ncdc
Copy link
Contributor

ncdc commented Sep 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit ac20d71 into kubernetes-retired:master Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants