-
Notifications
You must be signed in to change notification settings - Fork 65
✨ Add lint to make test command #230
✨ Add lint to make test command #230
Conversation
Hi @kashifest. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @chuckha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kashifest
/ok-to-test
an improvement for developers for sure /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pinging @ncdc, which IIRC has some thoughts around adding more pre-reqs to make targets |
Yes, I've got lots of thoughts too, but we should put them down in an issue first. I don't think this PR is the place to discuss broader improvements. I don't want to block this PR on us figuring out how to clean up the makefile vs hack/verify scripts problem. |
/lgtm |
What this PR does / why we need it:
Adds lint test to make test command