Remove redundant TODOs

[SataQiu]

What this PR does / why we need it:
Add APIServerEndpoint validation for JoinConfiguration

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[chuckha]

minor feedback.

I'm not sure what the use case for this is @fabriziopandini can you expand on your TODO a little bit more here? Maybe open an issue if it's significant enough?

[chuckha]

We could do away with this boolean and always validate, right? I think the optimization of running this validation code is not worth introducing the boolean and we should validate every time regardless.

[chuckha]

I'd put this whole thing in a function,

func validateAPIEndpoints(endpoint string, endpoints []string) error {
...
}

[fabriziopandini]

@SataQiu @chuckha
Considering that in all other cases like e.g. cluster name or network settings we are using values from the KubeConfig object without comparing them to the top-level object values, I'm in favor of simply removing the TODO without implementing/calling the validateAPIEndpoints func.

[SataQiu]

Thank you for your explanation @fabriziopandini
I understand your point. Let's ignore it for the moment.

[chuckha]

That's fine with me. Approving and lgtm as this is only comment changes.

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chuckha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment