Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Commit 5959669

Browse files
committed
⚠️ ClusterConfigration.Networking.* fields are now optional
Signed-off-by: Vince Prignano <[email protected]>
1 parent 5b53bd0 commit 5959669

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ bin
1111
*.test
1212

1313
# Output of the go coverage tool, specifically when used with LiteIDE
14+
out/
1415
*.out
1516

1617
# Kubernetes Generated files - skip generated files, except for vendored files

config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigs.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,9 +298,7 @@ spec:
298298
Defaults to "10.96.0.0/12".
299299
type: string
300300
required:
301-
- dnsDomain
302301
- podSubnet
303-
- serviceSubnet
304302
type: object
305303
scheduler:
306304
description: Scheduler contains extra settings for the scheduler

config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigtemplates.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,9 +317,7 @@ spec:
317317
services. Defaults to "10.96.0.0/12".
318318
type: string
319319
required:
320-
- dnsDomain
321320
- podSubnet
322-
- serviceSubnet
323321
type: object
324322
scheduler:
325323
description: Scheduler contains extra settings for the scheduler

kubeadm/v1beta1/types.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,11 +227,13 @@ type NodeRegistrationOptions struct {
227227
// Networking contains elements describing cluster's networking configuration
228228
type Networking struct {
229229
// ServiceSubnet is the subnet used by k8s services. Defaults to "10.96.0.0/12".
230-
ServiceSubnet string `json:"serviceSubnet"`
230+
// +optional
231+
ServiceSubnet string `json:"serviceSubnet,omitempty"`
231232
// PodSubnet is the subnet used by pods.
232233
PodSubnet string `json:"podSubnet"`
233234
// DNSDomain is the dns domain used by k8s services. Defaults to "cluster.local".
234-
DNSDomain string `json:"dnsDomain"`
235+
// +optional
236+
DNSDomain string `json:"dnsDomain,omitempty"`
235237
}
236238

237239
// BootstrapToken describes one bootstrap token, stored as a Secret in the cluster

0 commit comments

Comments
 (0)