-
Notifications
You must be signed in to change notification settings - Fork 59
Add package standardflags for -automaxprocs commandline argument #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The AddAutomaxprocs() function adds the -automaxprocs boolean flag to the commandline options. By default the flag is disabled. Applications can call EnableAutomaxprocs() to enable it during startup.
/cc jsafrane |
What are the requirements for using this flag properly? |
The flag only has effect when the container where the application runs has CPU limits configured. The maxprocs package reads the CPU quota from cgroups under |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, nixpanic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-csi/csi-lib-utils#193 added a flag across all the sidecars. In this repo that flag should only be defined once.
kubernetes-csi/csi-lib-utils#193 added a flag across all the sidecars. In this repo that flag should only be defined once.
kubernetes-csi/csi-lib-utils#193 added a flag across all the sidecars. In this repo that flag should only be defined once.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The new -automaxprocs flag can be used to set the GOMAXPROCS environment variable to match the configured Linux container CPU quota.
Which issue(s) this PR fixes:
Related: kubernetes-csi/node-driver-registrar#495
Special notes for your reviewer:
Applications can call EnableAutomaxprocs() to enable it during startup.
Does this PR introduce a user-facing change?: