Skip to content

protosanitizer: fix panic if enum value is not found #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

protosanitizer: fix panic if enum value is not found #188

merged 1 commit into from
Jan 7, 2025

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Jan 4, 2025

What type of PR is this?

/kind bug

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #184

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

protosanitizer: fix panic if enum value is not found

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 4, 2025
@huww98
Copy link
Contributor Author

huww98 commented Jan 4, 2025

/cc @jsafrane

@k8s-ci-robot k8s-ci-robot requested a review from jsafrane January 4, 2025 10:59
@huww98 huww98 force-pushed the not-found-enum-value branch from 13f8e9b to c4df6cb Compare January 4, 2025 11:05
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 4, 2025
@carlory
Copy link
Member

carlory commented Jan 6, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2025
@jsafrane
Copy link
Contributor

jsafrane commented Jan 7, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit e0fa89d into kubernetes-csi:master Jan 7, 2025
3 checks passed
@nixpanic nixpanic mentioned this pull request May 16, 2025
Draft
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request May 16, 2025
@nixpanic
rebase: update external-resizer sidecar to v1.13.2
e7ff31e 
The v1.13.2 build contains csi-lib-utils v0.21 which addresses a panic
when `GET_SNAPSHOT` is part of the ControllerCapabilities (unknown value
for an enum).

See-also: kubernetes-csi/csi-lib-utils#188
Signed-off-by: Niels de Vos <[email protected]>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request May 20, 2025
@nixpanic
rebase: update external-resizer sidecar to v1.13.2
a2e984d 
The v1.13.2 build contains csi-lib-utils v0.21 which addresses a panic
when `GET_SNAPSHOT` is part of the ControllerCapabilities (unknown value
for an enum).

See-also: kubernetes-csi/csi-lib-utils#188
Signed-off-by: Niels de Vos <[email protected]>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request May 20, 2025
@nixpanic
rebase: update external-resizer sidecar to v1.13.2
08f78bc 
The v1.13.2 build contains csi-lib-utils v0.21 which addresses a panic
when `GET_SNAPSHOT` is part of the ControllerCapabilities (unknown value
for an enum).

See-also: kubernetes-csi/csi-lib-utils#188
Signed-off-by: Niels de Vos <[email protected]>
nixpanic added a commit to nixpanic/rook that referenced this pull request May 20, 2025
@nixpanic
csi: update Kubernetes CSI sidecar images to current versions
a9b7bb7 
The Kubernetes CSI sidecars have had several releases that were not
included in deployments by Rook yet, update them to the versions that
are available today:

- csi-node-driver-registrar:v2.13.1
- csi-provisioner:v5.1.1
- csi-attacher:v4.8.1
- csi-resizer:v1.13.2
- csi-snapshotter:v8.2.1

This change is important, because Ceph-CSI will implement the new
Controller.GetSnapshot CSI procedure. A bug in csi-lib-utils causes a
panic when a ControllerCapability is provided, but not (yet) known to
the CSI sidecars. The updated sidecars consume a version of
csi-lib-utils with a fix for that panic.

See-also: kubernetes-csi/csi-lib-utils#188
Signed-off-by: Niels de Vos <[email protected]>
nixpanic added a commit to nixpanic/rook that referenced this pull request May 20, 2025
@nixpanic
csi: update Kubernetes CSI sidecar images to current versions
b61d391 
The Kubernetes CSI sidecars have had several releases that were not
included in deployments by Rook yet, update them to the versions that
are available today:

- csi-node-driver-registrar:v2.13.1
- csi-provisioner:v5.2.0
- csi-attacher:v4.8.1
- csi-resizer:v1.13.2
- csi-snapshotter:v8.2.1

This change is important, because Ceph-CSI will implement the new
Controller.GetSnapshot CSI procedure. A bug in csi-lib-utils causes a
panic when a ControllerCapability is provided, but not (yet) known to
the CSI sidecars. The updated sidecars consume a version of
csi-lib-utils with a fix for that panic.

See-also: kubernetes-csi/csi-lib-utils#188
Signed-off-by: Niels de Vos <[email protected]>
nixpanic added a commit to nixpanic/rook that referenced this pull request May 20, 2025
@nixpanic
csi: update Kubernetes CSI sidecar images to current versions
a168c40 
The Kubernetes CSI sidecars have had several releases that were not
included in deployments by Rook yet, update them to the versions that
are available today:

- csi-attacher:v4.8.1
- csi-provisioner:v5.2.0
- csi-resizer:v1.13.2
- csi-snapshotter:v8.2.1

This change is important, because Ceph-CSI will implement the new
Controller.GetSnapshot CSI procedure. A bug in csi-lib-utils causes a
panic when a ControllerCapability is provided, but not (yet) known to
the CSI sidecars. The updated sidecars consume a version of
csi-lib-utils with a fix for that panic.

See-also: kubernetes-csi/csi-lib-utils#188
Signed-off-by: Niels de Vos <[email protected]>
@nixpanic nixpanic mentioned this pull request May 20, 2025
Merged
6 tasks
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request May 20, 2025
@nixpanic
rebase: update external-resizer sidecar to v1.13.2
f8eb026 
The v1.13.2 build contains csi-lib-utils v0.21 which addresses a panic
when `GET_SNAPSHOT` is part of the ControllerCapabilities (unknown value
for an enum).

See-also: kubernetes-csi/csi-lib-utils#188
Signed-off-by: Niels de Vos <[email protected]>
mergify bot pushed a commit to rook/rook that referenced this pull request May 20, 2025
@nixpanic @mergify
csi: update Kubernetes CSI sidecar images to current versions
0d57154 
The Kubernetes CSI sidecars have had several releases that were not
included in deployments by Rook yet, update them to the versions that
are available today:

- csi-attacher:v4.8.1
- csi-provisioner:v5.2.0
- csi-resizer:v1.13.2
- csi-snapshotter:v8.2.1

This change is important, because Ceph-CSI will implement the new
Controller.GetSnapshot CSI procedure. A bug in csi-lib-utils causes a
panic when a ControllerCapability is provided, but not (yet) known to
the CSI sidecars. The updated sidecars consume a version of
csi-lib-utils with a fix for that panic.

See-also: kubernetes-csi/csi-lib-utils#188
Signed-off-by: Niels de Vos <[email protected]>
(cherry picked from commit a168c40)
@mergify mergify bot mentioned this pull request May 20, 2025
Merged
6 tasks
@nixpanic nixpanic mentioned this pull request May 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory Awaiting requested review from carlory

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huww98 @k8s-ci-robot @carlory @jsafrane