Skip to content

duplicate functions in connection and rpc package #30

Closed
@Madhu-1

Description

@Madhu-1

I see below functions are present on both connection and rpc package

func GetDriverName(ctx context.Context, conn *grpc.ClientConn) (string, error)

func GetPluginCapabilities(ctx context.Context, conn *grpc.ClientConn)

func GetControllerCapabilities(ctx context.Context, conn *grpc.ClientConn) (ControllerCapabilitySet, error)

func ProbeForever(conn *grpc.ClientConn, singleProbeTimeout time.Duration) error 

func probeOnce(conn *grpc.ClientConn, timeout time.Duration) 

func Probe(ctx context.Context, conn *grpc.ClientConn) (ready bool, err error) 

is this intentional or do we need to remove duplicate functions and make use of a single package?
if we need to remove it. I can do it.

CC @msau42 @pohly

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions