Skip to content

Updated external-snapshot-metadata sidecar support to its alpha level #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updated external-snapshot-metadata sidecar support to its alpha level #595

wants to merge 4 commits into from

Conversation

carlbraganza
Copy link

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #594

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 27, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2025
@carlbraganza
Updated instructions in docs/example-snapshot-metadata.md for the
3963162 
alpha release of the external snapshot metadata sidecar.
@carlbraganza carlbraganza force-pushed the update-example-snapshot-metadata branch from 7097bcd to 3963162 Compare March 28, 2025 00:48
PrasadG193
PrasadG193 reviewed Apr 1, 2025
View reviewed changes
docs/example-snapshot-metadata.md
```

This client performs following actions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think its a good idea to summarize actions performed by the client behind the scene to give more clarity?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It made a lot of sense before but now it repeats what is present in the external-snapshot-metadata repo and the documentation.

@carlbraganza carlbraganza requested a review from PrasadG193 April 2, 2025 12:52
Rakshith-R
Rakshith-R reviewed Apr 3, 2025
View reviewed changes
Copy link

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,
Thanks !

@Rakshith-R
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@Rakshith-R
Copy link

/cc @xing-yang

@k8s-ci-robot k8s-ci-robot requested a review from xing-yang April 8, 2025 06:50
iPraveenParihar
iPraveenParihar suggested changes Apr 8, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
Rakshith-R
Rakshith-R approved these changes Apr 9, 2025
View reviewed changes
Copy link

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2025
@carlbraganza
Copy link
Author

carlbraganza commented Apr 9, 2025 •
edited
Loading

/assign @msau42
/unassign @Rakshith-R

iPraveenParihar
iPraveenParihar approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@iPraveenParihar iPraveenParihar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@iPraveenParihar: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlbraganza, iPraveenParihar, Rakshith-R
Once this PR has been reviewed and has the lgtm label, please ask for approval from msau42. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

PrasadG193
PrasadG193 reviewed Apr 10, 2025
View reviewed changes
docs/example-snapshot-metadata.md
```
2. Execute the deploy script to setup the hostpath plugin driver with the Kubernetes SnapshotMetadata service:
```
SNAPSHOT_METADATA_TESTS=true HOSTPATHPLUGIN_REGISTRY=registry.k8s.io/sig-storage HOSTPATHPLUGIN_TAG=v1.16.1 ./deploy/kubernetes-latest/deploy.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SNAPSHOT_METADATA_TESTS=true HOSTPATHPLUGIN_REGISTRY=registry.k8s.io/sig-storage HOSTPATHPLUGIN_TAG=v1.16.1 ./deploy/kubernetes-latest/deploy.sh
SNAPSHOT_METADATA_TESTS=true ./deploy/kubernetes-latest/deploy.sh

We don't need to override the registry and tag as the latest released hostpath driver has SnapshotMetadata API support

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about that? When I last tried it out (just before KubeCon) it failed without explicitly specifying the tag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlbraganza looks like we didn't update the image tag for hostpath plugin deployment to latest release.
This will work once the tag is updated to the latest. We can do that in the same PR as well
https://github.com/kubernetes-csi/csi-driver-host-path/pull/607/files

docs/example-snapshot-metadata.md
```
Specifying the `SNAPSHOT_METADATA_TESTS=true` environment variable causes it to configure the `external-snapshot-metadata` sidecar
in the CSI hostpath driver Pod.
The `HOSTPATHPLUGIN_REGISTRY` and `HOSTPATHPLUGIN_TAG` environment variables are used to override defaults for the CSI hostpath driver image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `HOSTPATHPLUGIN_REGISTRY` and `HOSTPATHPLUGIN_TAG` environment variables are used to override defaults for the CSI hostpath driver image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 left review comments

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@pohly pohly Awaiting requested review from pohly

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@msau42 msau42

@Rakshith-R Rakshith-R

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update support for the external-snapshot-metadata sidecar to its alpha level
6 participants
@carlbraganza @Rakshith-R @k8s-ci-robot @PrasadG193 @iPraveenParihar @msau42