Skip to content

Remove snapshot e2e testing from alpha versions. #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

msau42
Copy link
Collaborator

@msau42 msau42 commented Mar 2, 2020

What type of PR is this?
//kind failing-test

What this PR does / why we need it:
Disables snapshot e2es for 1.16 deployment.

prow.sh uses the e2e version that matches the k8s version. Skew testing
(driver version != k8s version) doesn't work for alpha features.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

prow.sh uses the e2e version that matches the k8s version. Skew testing
(driver version != k8s version) doesn't work for alpha features.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 2, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2020
@msau42
Copy link
Collaborator Author

msau42 commented Mar 2, 2020

/assign @xing-yang

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 2, 2020
@msau42
Copy link
Collaborator Author

msau42 commented Mar 2, 2020

@xing-yang
Copy link
Contributor

Should we also remove "snapshotter" folder and "hostpath/csi-hostpath-snapshotter.yaml" under kubernetes-1.15 and kubernetes-1.16?

@msau42
Copy link
Collaborator Author

msau42 commented Mar 2, 2020

Should we also remove "snapshotter" folder and "hostpath/csi-hostpath-snapshotter.yaml" under kubernetes-1.15 and kubernetes-1.16?

I think people may still want to deploy hostpath driver on older versions. We just can't test it in our e2es

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b44e56a into kubernetes-csi:master Mar 2, 2020
TerryHowe pushed a commit to TerryHowe/csi-driver-host-path that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants