Skip to content

Update support matrix #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2019
Merged

Update support matrix #924

merged 1 commit into from
Aug 21, 2019

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Aug 9, 2019

Fix issue #921. As discussed I only removed up to v1.9.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 9, 2019
micw523
micw523 reviewed Aug 9, 2019
View reviewed changes
Copy link
Contributor

@micw523 micw523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if the commits are squashed and the spelling of the commit messages are spelled correctly (I guess I’m just being picky here).

@oz123
Remove old client versions (>v1.9) from support matrix
c630528 
 * Add updating of support matrix to REALEASE.md
   This will help future maintainers and prevent the table
   from becoming huge again.
@oz123 oz123 force-pushed the update-support-matrix branch from 2a9edb5 to c630528 Compare August 9, 2019 11:47
@oz123
Copy link
Contributor Author

oz123 commented Aug 9, 2019

@micw523 as you wished :-) spelling corrections and squashing.

@micw523
Copy link
Contributor

micw523 commented Aug 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2019
@yliaog
Copy link
Contributor

yliaog commented Aug 13, 2019

/assign @roycaihw

@oz123
Copy link
Contributor Author

oz123 commented Aug 21, 2019

@roycaihw can this be merged?

@yliaog
Copy link
Contributor

yliaog commented Aug 21, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oz123, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 08fefc3 into kubernetes-client:master Aug 21, 2019
@oz123 oz123 deleted the update-support-matrix branch September 1, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micw523 micw523 micw523 left review comments

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@roycaihw roycaihw

@micw523 micw523

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oz123 @micw523 @yliaog @k8s-ci-robot @roycaihw