kube-init.sh: die is not a command

[TomasTomecek]

die is not a shell command

[k8s-ci-robot]

Welcome @TomasTomecek!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[roycaihw]

/cc @yliaog

[yliaog]

do you know why 'die' is not available?

[micw523]

/cc
I did a little investigation.
"die" is actually a Perl command and not a bash command. When I refreshed our CI script I kept the "die" in place b/c the code was there and I thought it would let the program exit.

I think it would be OK as long as the exit return value makes sense.

[micw523]

Why do you want to return 33?

[TomasTomecek]

Why do you want to return 33?

would you ask me this question if I wrote 1, 2 or 3? I dunno, it's just a number, no meaning.

[micw523]

I probably still would have asked if you returned 2 or 3. 1 is commonly used for error exits isn't it?

Another reason I asked is that the original behavior (probably) wants to return the line number that it exited from. I'll have to leave the judgment to Roy and Yu on this one. I'm fine with it if they say it's ok.

[yliaog]

https://shapeshed.com/unix-exit-codes/

1 is likely a better choice.

I'm curious about what happened? the script has been in existence since 2017. what change has caused the problem?

[TomasTomecek]

I'm curious about what happened? the script has been in existence since 2017. what change has caused the problem?

I used the script in a vagrant VM to run tests - sadly minikube did not start and since there is no set -e, bash just said 'die: command not found' and kept on going

[yliaog]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomasTomecek, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment