-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Added examples for Jobs and Hooks #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
CLA has been completed. Please verify. |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ratanboddu If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/check-cla |
/assign @lavalamp |
ping @lavalamp |
@ratanboddu It looks like you changed all the permissions in the examples folder, could you undo that? Also, you'll probably need to add the copyright lines like lines 1-17 here: https://github.com/kubernetes-client/python/blob/master/examples/remote_cluster.py#L1. |
I have made the changes, added a few extra examples and raised a new PR #898 |
@ratanboddu please close this PR, thanks. |
@scottilee |
/hold |
@ratanboddu can you also make sure to add the copyright header (e.g., https://github.com/kubernetes-client/python-base/blob/master/hack/boilerplate/boilerplate.sh.txt) as well as try to give a more descriptive explanation of what your script is doing in the comment at the top. For example, what should be the end result of running the script and why would I run this script in a Kuberenetes cluster. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@ratanboddu: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added examples for creating a Job using Kubernetes Client, also added examples for Hooks (Pre Stop and Post Start)