Skip to content

Updating kubernetes-client owners with sai-adarsh #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Sai-Adarsh
Copy link
Contributor

Would like to join a GitHub team of kubernetes-client, and highly interested to join as a reviewer. Have previously merged a fix (#734).

Would like to join a GitHub team of kubernetes-client, and highly interested to join as a reviewer. Have previously merged a fix (kubernetes-client#734).
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sai-Adarsh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: roycaihw

If they are not already assigned, you can assign the PR to them by writing /assign @roycaihw in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2019
@Sai-Adarsh
Copy link
Contributor Author

/assign @lavalamp

@micw523
Copy link
Contributor

micw523 commented Mar 9, 2019

Please read the document for k8s community roles...
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2019
@Sai-Adarsh
Copy link
Contributor Author

Please read the document for k8s community roles...
/hold

kubernetes/org#588 👍

@roycaihw
Copy link
Member

hi @Sai-Adarsh, happy to hear that you are interested in contributing to this repo :) You don't have to be added to OWNER file to review PRs. I'd suggest starting with making consistent contribution in review and authorship to a subproject if you want to be in an OWNER file

also please take a look at https://github.com/kubernetes/community/blob/master/community-membership.md#reviewer

/close

@k8s-ci-robot
Copy link
Contributor

@roycaihw: Closed this PR.

In response to this:

hi @Sai-Adarsh, happy to hear that you are interested in contributing to this repo :) You don't have to be added to OWNER file to review PRs. I'd suggest starting with making consistent contribution in review and authorship to a subproject if you want to be in an OWNER file

also please take a look at https://github.com/kubernetes/community/blob/master/community-membership.md#reviewer

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants