Fixes Setup.py error on Windows #676 #734
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| if ! [ -x "$(command -v python)" ]; | ||
| then | ||
| echo "Python environment notfound.." | ||
| else | ||
| echo "Python environment found.." | ||
| fi | ||
| python --version | ||
| cp -R ../kubernetes/base/* ../kubernetes/ | ||
|
There was a problem hiding this comment. what's the reason to do the 'cp -R' above? There was a problem hiding this comment.
"When we clone submodule with git the folders in the /kubernetes/base is supposed to be symbolically linked in the /kubernetes directory. In Windows this is not done. For a Windows developer, we’ll need to have a script copying all the base/* folders into */. " ^ is what @micw523 requested in his issue. so 'cp -R' does the job.
Sai-Adarsh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| cd ../ && python setup.py install | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check windows batch scripting syntax for
if