Skip to content

Support Python 3.7 for Travis CI #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2018
Merged

Support Python 3.7 for Travis CI #685

merged 1 commit into from
Nov 13, 2018

Conversation

micw523
Copy link
Contributor

@micw523 micw523 commented Nov 10, 2018 •
edited
Loading

This PR prepares for a Python 3.7 support from Travis CI.
Edit:
Travis CI do support Python 3.7 now. It requires OpenSSL 1.0.2+ and Ubuntu 16.04+
and luckily we switched to the platform on our Travis CI update...
See travis-ci/travis-ci#9069 (comment)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 10, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 10, 2018
@micw523 micw523 changed the title [WIP] Prepare for Python 3.7 tests Support Python 3.7 for Travis CI Nov 10, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2018
@micw523
Copy link
Contributor Author

micw523 commented Nov 10, 2018

/remove hold

@micw523
Copy link
Contributor Author

micw523 commented Nov 10, 2018

/hold cancel
just couldn't remember the commands...
/this-is-not-fine

@k8s-ci-robot
Copy link
Contributor

@micw523: dog image

In response to this:

/hold cancel
just couldn't remember the commands...
/this-is-not-fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2018
@micw523 micw523 mentioned this pull request Nov 10, 2018
Merged
roycaihw
roycaihw reviewed Nov 13, 2018
View reviewed changes
setup.py
@@ -77,5 +77,6 @@
"Programming Language :: Python :: 3.4",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will add 3.7 to the pypi supported versions badge in README (probably in next release)

@roycaihw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micw523, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit 35e6406 into kubernetes-client:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw roycaihw left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micw523 @k8s-ci-robot @roycaihw