Generate snapshot client in preparation for 8.0.0b1 release #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
against kubernetes 1.12.1 release (temp 1.12.2 openapi spec)
against kubernetes 1.12.1 release (temp 1.12.2 openapi spec)
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
roycaihw
commented
Oct 15, 2018
| @@ -3,7 +3,7 @@ No description provided (generated by Swagger Codegen https://github.com/swagger | |||
|
|
|||
| This Python package is automatically generated by the [Swagger Codegen](https://github.com/swagger-api/swagger-codegen) project: | |||
|
|
|||
| - API version: v1.12.1 | |||
| - API version: v1.12.2 | |||
There was a problem hiding this comment.
As discussed in #631 (comment), currently Kubernetes latest release is 1.12.1. We are generating this client against the temporary 1.12.2 openapi spec file. I will file an issue in gen repo to track the UX improvement.
/assign @yliaog
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... against kubernetes 1.12.1 release (temp 1.12.2 openapi spec).
Also update CHANGELOG. I verified that there are only two cherry-pick commits that modified the upstream openapi spec after 1.12.0 is cut. Therefore the CHANGELOG only collects those two changes.
In my previous PR updating python-base submodule, I forgot that API changes should be checked into master branch. I should have combined these two PRs into one to save review bandwidth... The next step is to merge master into release-8.0 branch and re-generate client (should be only version constants change)