binary websocket support, plus examples #494
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, in #476 we noted that we currently cannot stream binary data to/from pods so no feature like
kubectl cp
(and probably others) could be implemented.I've worked on that, two PR came out. The first is kubernetes-client/python-base#52 and when it will be merged, this one will then unlock binary streams and provide couple examples on how to do it.
Problem: I had to patch core_v1_api.py swagger generated code, as swagger itself seems to ignore binary type specification. I'm currently investigating on that.
In the meanwhile I could produce a temporary patch in
scripts/
and apply it whenclient-update
ing but I'd like to know what do you think about that part.Thank you, ciao