API change for v6.0.0b1 #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add PATCH to custom_objects_api documentation update: never let cluster-scoped resources skip webhooks
mbohlool
reviewed
Mar 9, 2018
| # v6.0.0b1 | ||
| - Update to Kubernetes 1.10 cluster | ||
| - New API: add PATCH to CustomObjectsApi [kubernetes-client/gen#53](https://github.com/kubernetes-client/gen/pull/53) | ||
| - Documentation update: never let cluster-scoped resources skip webhooks [kubernetes/kubernetes#58185](https://github.com/kubernetes/kubernetes/pull/58185) |
There was a problem hiding this comment.
Just curious, are you manually generating this? I would be beneficial to all clients if we can automate this. I would create a tracking issue in gen repo for it.
There was a problem hiding this comment.
Yes, I manually checked the diff and tracked down the original PRs. It would help a lot if gen could detect the openapi spec change since last time we generated the client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committing generated API change for v6.0.0b1:
also updating README and CHANGELOG