Reapply "Implementation for /exec using websocket" #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reapplies PR kubernetes-client#120 that was removed by kubernetes-client#353. Below is the original commit message. inspired by the POC from @chekolyn * Adds a new requirement on websocket-client * Add a new class WSClient that uses WebSocketApp from the websocket-client. * Make sure we pass Authorization header * Make sure we honor the SSL settings in configuration * Some of the code will get overwritten when we generate fresh classes from swagger definition. To remind us added a e2e test so we don't lose the changes * Added a new configuration option to enable/disable failures when hostnames in certificates don't match Fixes kubernetes-client#58 Fixes kubernetes-client#409
k8s-ci-robot
added
size/L
|
@dulek the websocket related code is still there ... under https://github.com/kubernetes-client/python-base/blob/master/stream/ws_client.py |
|
@dims: Oh, so I assume only change to api_client.py is needed? |
|
@dulek api_client.py is an auto-generated file and we should not edit it. Please refer to example here for how to do exec calls in the new python client world :) |
|
Oh. Thanks for pointing it out and sorry for all the fuss! |
|
@dulek You are welcome and no worries. Let me know how your experience went with exec calls. Any improvements to that process would be most welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reapplies PR #120 that was removed by #353. Below is the
original commit message.
inspired by the POC from @chekolyn
the websocket-client.
fresh classes from swagger definition. To remind us
added a e2e test so we don't lose the changes
when hostnames in certificates don't match
Fixes #58
Fixes #409