Skip to content

Update master to follow kubernetes 1.7 branch #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2017

Conversation

mbohlool
Copy link
Contributor

Some new API groups and some changes in API parameters in 1.7. Most part of this PR is auto-generated but it wouldn't be a bad idea to go over it really fast.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2017
@mbohlool mbohlool requested review from dims and pokoli June 29, 2017 08:36
@dims
Copy link
Collaborator

dims commented Jun 29, 2017

LGTM 👍

Copy link

@pokoli pokoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should fix the test giving a timeout.

Probably rebuilding will fix as it's a timeout, but it's strange...

Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@mbohlool
Copy link
Contributor Author

CI tests are failing and it is not because of this PR. They are failing on master too. I am trying to fix them https://github.com/kubernetes-incubator/client-python/pull/277/files with no success. You can see the history of failures here https://travis-ci.org/kubernetes-incubator/client-python/pull_requests. Let me know if you have any ideas. (I can get it pass locally but not on Travis).

@mbohlool
Copy link
Contributor Author

I think I figured it out.

@mbohlool mbohlool merged commit 5e268fb into kubernetes-client:master Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants