Stop using deprecated urllib3 API

[arcivanov]

fixes #2169

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Stop using deprecated urllib3 API.

Which issue(s) this PR fixes:

Fixes #2169

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

• 5b9afe2 Stop using deprecated urllib3 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @arcivanov!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arcivanov
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yliaog]

as the start of the file shows:

Generated by: https://openapi-generator.tech

the file is generated, fix needs to go to the generator.

[arcivanov]

@yliaog will do, thanks!

[arcivanov]

@yliaog well, this is curious. Openapi-generator for python switched to httpx from requests in the year 2020: https://github.com/openapi-generators/openapi-python-client/blob/fe76d59a2bae07b884cca75304734762547557e1/CHANGELOG.md#020---2020-03-22

What version of the generator are we even using?

[yliaog]

export OPENAPI_GENERATOR_COMMIT="v4.3.0"

python/scripts/update-client.sh

Line 25 in 1992802

export OPENAPI_GENERATOR_COMMIT="v4.3.0"

[arcivanov]

@yliaog the version v4.3.0 is prehistoric as well (current is 7.2.0) and I feel there is a zero chance that the upstream will entertain a patch at this point in time.

Would you be amenable to a post-generation patch file similar to this?

python/scripts/update-client.sh

Line 75 in 1992802

git apply "${SCRIPT_ROOT}/rest_client_patch.diff"

[arcivanov]

@yliaog this has been fixed in the later versions, namely here: https://github.com/OpenAPITools/openapi-generator/blob/a5d3fb4f601e4bced19f39cb6d82799a71531282/samples/client/echo_api/python/openapi_client/rest.py#L54

Would you entertain a patch?

[yliaog]

a patch is fine, provide comment on why is the patch, and when it can be removed.