Skip to content

Move config and watch into a base folder to prepare for multi-repo client #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2017

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented May 9, 2017

We need to separate our base and generated code so other users can create their own client and use our base utilities. This is a required restructuring explained here:

https://github.com/kubernetes-client/community/blob/master/design-docs/clients-library-structure.md

config and watch package has been moved into a base package as well as api_client rest and configuration classes. Symlinks created to make everything work as before.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2017
@codecov-io
Copy link

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files           9        9           
  Lines         681      681           
=======================================
  Hits          644      644           
  Misses         37       37
Impacted Files Coverage Δ
kubernetes/base/config/incluster_config.py 88.88% <ø> (ø)
kubernetes/base/config/__init__.py 100% <ø> (ø)
kubernetes/base/watch/__init__.py 100% <ø> (ø)
kubernetes/base/watch/watch.py 98.33% <ø> (ø)
kubernetes/base/config/kube_config.py 96.47% <ø> (ø)
kubernetes/base/config/config_exception.py 100% <ø> (ø)
kubernetes/base/watch/watch_test.py 96.42% <ø> (ø)
kubernetes/base/config/kube_config_test.py 92.22% <ø> (ø)
kubernetes/base/config/incluster_config_test.py 97.29% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4729e68...1ebceb6. Read the comment docs.

@mbohlool
Copy link
Contributor Author

@dims this is ready to review.

@dims
Copy link
Collaborator

dims commented May 11, 2017

Looks like just things moving around :) /lgtm

@mbohlool
Copy link
Contributor Author

Thanks

@mbohlool mbohlool merged commit dbe83ef into kubernetes-client:master May 11, 2017
yliaog pushed a commit to yliaog/client-python that referenced this pull request Jan 8, 2022
…e-exception

dynamic-e2e: fix the error expectation in the discovery retry logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants