Skip to content

Prevent ConstructorError when parsing YAML containing '=' scalars #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

juergenhoetzel
Copy link
Contributor

pyyaml assignes '=' to tag:yaml.org,2002:value even though there's no constructor for it. Removing the implicit resolver for '=' fixes the issue.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Currently applying YAML documents containing the = scalar results in an error. Minimal example:

apiVersion: v1
kind: ConfigMap
metadata:
  name: demo
data:
  equal: =
from kubernetes import client, config, utils


def main():
    config.load_kube_config()
    k8s_client = client.ApiClient()
    yaml_file = "configmap.yml"
    utils.create_from_yaml(k8s_client, yaml_file, verbose=True)


if __name__ == "__main__":
    main()

results in:

yaml.constructor.ConstructorError: could not determine a constructor for the tag 'tag:yaml.org,2002:value'
  in "/home/juergen/ghq/github.com/kubernetes-client/python/configmap.yml", line 6, column 10

While the above example is contrived, this issue also hit me in real world when parsing the Prometheus operator CRD

NONE

pyyaml assignes '=' to tag:yaml.org,2002:value even though there's
no constructor for it. Removing the implicit resolver for '=' fixes
the issue.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 30, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @juergenhoetzel!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from roycaihw and yliaog April 30, 2023 16:32
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2023
@roycaihw
Copy link
Member

/assign @yliaog

@yliaog
Copy link
Contributor

yliaog commented May 24, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juergenhoetzel, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9a2d5e4 into kubernetes-client:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants