Skip to content

Add e2e test for strategic merge patch #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add e2e test for strategic merge patch #1898

wants to merge 5 commits into from

Conversation

pmareke
Copy link
Contributor

@pmareke pmareke commented Sep 27, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add a test sending patches to a ConfigMap API using both json and merge strategies

Which issue(s) this PR fixes:

Fixes #951

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 27, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 27, 2022

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pmareke
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval by writing /assign @yliaog in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2022
@pmareke pmareke changed the title Feature/add e2e test for strategic merge patch Add e2e test for strategic merge patch Sep 27, 2022
@pmareke pmareke closed this Sep 27, 2022
@pmareke pmareke deleted the feature/add-e2e-test-for-strategic-merge-patch branch September 27, 2022 06:52
@pmareke pmareke restored the feature/add-e2e-test-for-strategic-merge-patch branch September 27, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e test for strategic merge patch
2 participants