Skip to content

add e2e test for strategic merge patch #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

add e2e test for strategic merge patch #1897

wants to merge 5 commits into from

Conversation

pmareke
Copy link
Contributor

@pmareke pmareke commented Sep 26, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add a test sending patches to a ConfigMap API using both json and merge strategies

Which issue(s) this PR fixes:

Fixes #951

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

@pmareke: The label(s) kind/missing-test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind missing-test

What this PR does / why we need it:

Add a test sending patches to a ConfigMap API using both json and merge strategies

Which issue(s) this PR fixes:

Fixes #951

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pmareke
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval by writing /assign @yliaog in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 26, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 26, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @pmareke!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 26, 2022
@pmareke
Copy link
Contributor Author

pmareke commented Sep 26, 2022

/test ?

@k8s-ci-robot
Copy link
Contributor

@pmareke: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmareke
Copy link
Contributor Author

pmareke commented Sep 26, 2022

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 26, 2022
@pmareke pmareke changed the title Fear/add e2e test for strategic merge patch add e2e test for strategic merge patch Sep 27, 2022
@pmareke pmareke closed this Sep 27, 2022
@pmareke pmareke deleted the fear/add-e2e-test-for-strategic-merge-patch branch September 27, 2022 06:37
@pmareke pmareke reopened this Sep 27, 2022
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

1 similar comment
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 27, 2022
@pmareke pmareke closed this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e test for strategic merge patch
2 participants