Skip to content

Update CHANGELOG and README in master branch #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2021
Merged

Update CHANGELOG and README in master branch #1451

merged 1 commit into from
May 3, 2021

Conversation

roycaihw
Copy link
Member

@roycaihw roycaihw commented May 3, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Copy the CHANGELOG of v17.17.0b1 and v18.17.0a1 from the release branches. Also update README to include v18.

Does this PR introduce a user-facing change?

NONE

/cc @yliaog @scottilee

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 3, 2021
@k8s-ci-robot k8s-ci-robot requested a review from yliaog May 3, 2021 04:02
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 3, 2021
@k8s-ci-robot
Copy link
Contributor

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Copy the CHANGELOG of v17.17.0b1 and v18.17.0a1 from the release branches. Also update README to include v18.

Does this PR introduce a user-facing change?

NONE

/cc @yliaog @scottilee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 3, 2021
yliaog
yliaog reviewed May 3, 2021
View reviewed changes
README.md
@@ -124,6 +125,7 @@ between client-python versions.
| 12.0 Alpha/Beta | Kubernetes main repo, 1.16 branch | ✗ |
| 12.0 | Kubernetes main repo, 1.16 branch | ✓ |
| 17.0 Alpha/Beta | Kubernetes main repo, 1.17 branch | ✓ |
| 18.0 Alpha/Beta | Kubernetes main repo, 1.17 branch | ✓ |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.18 branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated
@@ -87,6 +87,7 @@ supported versions of Kubernetes clusters.
- [client 11.y.z](https://pypi.org/project/kubernetes/11.0.0/): Kubernetes 1.14 or below (+-), Kubernetes 1.15 (✓), Kubernetes 1.16 or above (+-)
- [client 12.y.z](https://pypi.org/project/kubernetes/12.0.1/): Kubernetes 1.15 or below (+-), Kubernetes 1.16 (✓), Kubernetes 1.17 or above (+-)
- [client 17.y.z](https://pypi.org/project/kubernetes/17.14.0a1/): Kubernetes 1.16 or below (+-), Kubernetes 1.17 (✓), Kubernetes 1.18 or above (+-)
- [client 18.y.z](https://pypi.org/project/kubernetes/17.14.0a1/): Kubernetes 1.17 or below (+-), Kubernetes 1.18 (✓), Kubernetes 1.19 or above (+-)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pypi.org/project/kubernetes/17.14.0a1 needs to be updated to 18.y.z

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Nice catch!

@roycaihw
update CHANGELOG and README in master branch
abb2a6e 
to reflect the lastest v17 and v18 releases
@yliaog
Copy link
Contributor

yliaog commented May 3, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit b13b350 into kubernetes-client:master May 3, 2021
@roycaihw roycaihw deleted the update-readme branch May 9, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yliaog yliaog yliaog left review comments

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roycaihw @k8s-ci-robot @yliaog