Skip to content

Release 18.0 Snapshot #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Nov 24, 2020
Merged

Release 18.0 Snapshot #1319

merged 23 commits into from
Nov 24, 2020

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Nov 13, 2020 •
edited
Loading

  • Update submodule
  • Update constants
  • Generate client
  • Update CHANGELOG

TODO After Merge:

  • Cut alpha release for v18
  • Cherry-pick CHANGELOG and README into master

@palnabarun
Update submodule
2910f25 
Old: fd322f7
New: 2da2b98

Signed-off-by: Nabarun Pal <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 13, 2020
@palnabarun palnabarun changed the base branch from master to release-18.0 November 13, 2020 21:21
dependabot bot and others added 18 commits November 17, 2020 04:00
@dependabot @palnabarun
Bump actions/setup-python from v2.1.3 to v2.1.4
ddf3470 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from v2.1.3 to v2.1.4.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2.1.3...41b7212)

Signed-off-by: dependabot[bot] <[email protected]>
@palnabarun
Update hot patch section of release documentation
89ea530 
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun
Update CHANGELOG and README to reflect v12.0.0 and v12.0.1
c382d32 
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun
Update constants to reflect Client release 17.0.0
329b27a 
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun
Generate client 17.0.0
2132e24 
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun
Remove generated tests
86f621a 
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun
Fix custom objects API to preserve backward compatibility
7f1667e 
Reference:
- [kubernetes-client#866](kubernetes-client#866)
- [kubernetes-client#959](kubernetes-client#959)

Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun
Add kubernetes.client.apis as an alias to kubernetes.client.api
4cfbfd4 
Reference: kubernetes-client#974

Signed-off-by: Nabarun Pal <[email protected]>
@fabianvf @palnabarun
Add test to ensure kubernetes client threadpool is cleaned up
a3d90aa
@roycaihw @palnabarun
add a test for default configuration behavior
631386c
@palnabarun
Update CHANGELOG with v17.0.0-snapshot
7a4ffcf 
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun
Update README
161f123 
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun
Update constants to reflect Client release 18.0.0-snapshot
0fd7389 
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun
Generate client 18.0.0-snapshot
cd92c5d 
Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun
Fix custom objects API to preserve backward compatibility
e379ad2 
Reference:
- [kubernetes-client#866](kubernetes-client#866)
- [kubernetes-client#959](kubernetes-client#959)

Signed-off-by: Nabarun Pal <[email protected]>
@palnabarun
Add kubernetes.client.apis as an alias to kubernetes.client.api
9f880d8 
Reference: kubernetes-client#974

Signed-off-by: Nabarun Pal <[email protected]>
@fabianvf @palnabarun
Add test to ensure kubernetes client threadpool is cleaned up
b4a3fc2
@roycaihw @palnabarun
add a test for default configuration behavior
1c2be29
roycaihw
roycaihw reviewed Nov 17, 2020
View reviewed changes
CHANGELOG.md
- Python 2 had reached [End of Life](https://www.python.org/doc/sunset-python-2/) on January 1, 2020. The Kubernetes Python Client has dropped support for Python 2 from this release (v18.0.0) and will no longer provide support to older clients as per the [Kubernetes support policy](https://kubernetes.io/docs/setup/release/version-skew-policy/#supported-versions).

**API Change:**
- Fix bug in reflector that couldn't recover from "Too large resource version" errors ([#92537](https://github.com/kubernetes/kubernetes/pull/92537), [@wojtek-t](https://github.com/wojtek-t)) [SIG API Machinery]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in client-go reflector is unrelated to the python client. OTOH the change in API server error reporting is visible to the python client.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I kept it in the changelogs for the API server error exposure. Do you think adding a few more lines with the upstream CHANGELOG add value to this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thanks

CHANGELOG.md
- The Kubernetes Python client versioning scheme has changed. The version numbers used till Kubernetes Python Client v12.y.z lagged behind the actual Kubernetes minor version numbers. From this release, the client is moving a version format `vY.Z.P` where `Y` and `Z` are respectively from the Kubernetes version `v1.Y.Z` and `P` would incremented due to changes on the Python client side itself. Ref: https://github.com/kubernetes-client/python/issues/1244
- Python 2 had reached [End of Life](https://www.python.org/doc/sunset-python-2/) on January 1, 2020. The Kubernetes Python Client has dropped support for Python 2 from this release (v18.0.0) and will no longer provide support to older clients as per the [Kubernetes support policy](https://kubernetes.io/docs/setup/release/version-skew-policy/#supported-versions).

**API Change:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some major API change in "Generate client 18.0.0-snapshot":

kubernetes/client/api/apps_v1beta1_api.py                                          |  5658 ---
kubernetes/client/api/apps_v1beta2_api.py                                          |  9234 -----
kubernetes/client/api/extensions_v1beta1_api.py                                    |  9411 +----

Could you add a note about these APIs being removed from this client?

- the following deprecated APIs can no longer be served:
  - All resources under `apps/v1beta1` and `apps/v1beta2` - use `apps/v1` instead
  - `daemonsets`, `deployments`, `replicasets` resources under `extensions/v1beta1` - use `apps/v1` instead
  - `networkpolicies` resources under `extensions/v1beta1` - use `networking.k8s.io/v1` instead
  - `podsecuritypolicies` resources under `extensions/v1beta1` - use `policy/v1beta1` instead ([#85903](https://github.com/kubernetes/kubernetes/pull/85903), [@liggitt](https://github.com/liggitt)) [SIG API Machinery, Apps, Cluster Lifecycle, Instrumentation and Testing]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding me. I had forgotten to put the removal notices.

@roycaihw
Copy link
Member

LGTM overall. Thanks for putting the effort collecting the release notes.

It surprises me that we have way more changes in 1.18 (+66,885 −136,266) than in 1.17 (+22,657 −4,082). It looks like the openapi spec itself changed a lot.

kubernetes/swagger.json.unprocessed                                                | 82610 +++++++++++++++------------------
scripts/swagger.json                                                               | 40354 ++++++------------

It could be because the upstream dropped some deprecated APIs. Could you confirm that?

@palnabarun
Copy link
Member Author

It could be because the upstream dropped some deprecated APIs. Could you confirm that?

It may be due to the fact that release-18.0 doesn't have the latest changes in master and this PR also adds those changes in the release-18.0. This PR is ideally just 10 commits. The other 13 commits are updating the branch itself. We can split those changes into two different PRs if that makes sense.

@roycaihw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7a0e799 into kubernetes-client:release-18.0 Nov 24, 2020
@palnabarun palnabarun mentioned this pull request Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw roycaihw left review comments

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@palnabarun @roycaihw @k8s-ci-robot @fabianvf