-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Move several workflows to GitHub Actions #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move several workflows to GitHub Actions #1286
Conversation
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
Rotten issues close after 30d of inactivity. Send feedback to sig-contributor-experience at kubernetes/community. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@palnabarun: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
61c5eaf
to
9d5ce12
Compare
b6f5850
to
4182c42
Compare
1713c09
to
f256cb2
Compare
please squash some fix commits |
2950dd9
to
aba5f74
Compare
/retitle Move several workflows to GitHub Actions |
/release-note-none |
/kind cleanup |
4475c69
to
aba5f74
Compare
aba5f74
to
1d9c39c
Compare
The e2e here uses kind. The eventual goal would be to remove the use of minikube completely and use kind exclusively in conformance to general Kubernetes upstream usage. - Add kind cluster configs for all supported Kubernetes versions - Add GH Action workflows for end to end testing Signed-off-by: Nabarun Pal <[email protected]>
Signed-off-by: Nabarun Pal <[email protected]>
1d9c39c
to
b7a612b
Compare
@yliaog -- The commit history is clean now. I was testing things out earlier. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
The test results look good. @palnabarun Thanks!
# Update the config here whenever a new client snapshot is performed | ||
# This would eventually point to cluster with the latest Kubernetes version | ||
# as we sync with Kubernetes upstream | ||
config: .github/workflows/kind-configs/cluster-1.18.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to update the release doc. It can be done in a followup
- name: Install package | ||
run: python -m pip install -e . | ||
- name: Run End to End tests | ||
run: pytest -vvv -s kubernetes/e2e_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to pull the main repo and run the e2e tests in the python-base repo using Github Actions?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: palnabarun, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ref: #1257
Signed-off-by: Nabarun Pal [email protected]