Skip to content

Snapshot the Kubernetes 1.16 release #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 11, 2020
Merged

Snapshot the Kubernetes 1.16 release #1141

merged 4 commits into from
May 11, 2020

Conversation

palnabarun
Copy link
Member

  • Update version constants
  • Generate client
  • Apply hotfixes

@palnabarun
Update constants
3f0e7c7 
- KUBERNETES_BRANCH to "release-1.16"
- CLIENT_VERSION to "12.0.0-snapshot"
- DEVELOPMENT_STATUS to "3 - Alpha"
@palnabarun
Generate updated client
c206745
@palnabarun
Apply hotfixes
739665e
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2020
@k8s-ci-robot k8s-ci-robot requested review from roycaihw and yliaog April 9, 2020 23:52
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 9, 2020
@palnabarun
Copy link
Member Author

/assign @roycaihw @yliaog

@palnabarun
Copy link
Member Author

palnabarun commented Apr 9, 2020 •
edited
Loading

I had a doubt whether the API changes be put in CHANGELOG along with this PR or the alpha release PR.

What do you think?

Edit: Oops! Never mind. Saw your comment on the other PR. 😅

roycaihw
roycaihw reviewed Apr 10, 2020
View reviewed changes
Copy link
Member

@roycaihw roycaihw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @palnabarun. Would you mind collecting the API changes in CHANGELOG, or is @scottilee going to collect them in the 12.0.0a1 release PR?

scripts/constants.py

# Name of the release package
PACKAGE_NAME = "kubernetes"

# Stage of development, mainly used in setup.py's classifiers.
DEVELOPMENT_STATUS = "4 - Beta"
DEVELOPMENT_STATUS = "3 - Alpha"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we have been using Beta in the master branch (x.0.0-snapshot) meaning a "dev" status. It doesn't have any real effect since we don't publish the snapshot client. Perhaps Alpha fits it better. I think we can stick with one and don't need to toggle between Alpha and Beta in the future

Copy link
Member Author

@palnabarun palnabarun Apr 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was researching what should be the classifier for an upstream development branch, but couldn't find any concrete precedence for our use case.

I thought settling for Alpha would make more sense than Beta.

I think we can stick with one and don't need to toggle between Alpha and Beta in the future

👍

@palnabarun
Copy link
Member Author

palnabarun commented Apr 10, 2020 •
edited
Loading

Would you mind collecting the API changes in CHANGELOG, or is @scottilee going to collect them in the 12.0.0a1 release PR?

I was thinking that collecting them in the 12.0.0a1 PR would make more sense as one single commit can have all kinds of changes in the CHANGELOG and cherry-pick would thus become easier.

@palnabarun
Copy link
Member Author

/assign

@scottilee scottilee mentioned this pull request Apr 14, 2020
Closed
@roycaihw roycaihw mentioned this pull request Apr 27, 2020
Closed
@palnabarun
Copy link
Member Author

@roycaihw I have updated this PR with the API changes collected from upstream.

Added them under a heading v12.0.0a1-snapshot since I thought putting them under v12.0.0a1 would have been misleading as that would mean we have already released v12.0.0a1 client.

@palnabarun palnabarun force-pushed the snaphot-client-k8s-release-1.16 branch from 41dbde2 to afd837a Compare April 28, 2020 23:54
@palnabarun palnabarun mentioned this pull request May 11, 2020
Merged
roycaihw
roycaihw approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@roycaihw roycaihw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I noticed that kubernetes-client/gen#155 was not included. It could be included in this PR or in a separate one

/lgtm
/approve

CHANGELOG.md

Kubernetes API Version: 1.16.9

**API Change:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for collecting the API changes!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit d63282e into kubernetes-client:master May 11, 2020
@palnabarun
Copy link
Member Author

nit: I noticed that kubernetes-client/gen#155 was not included. It could be included in this PR or in a separate one

I cut this PR before that change went in. The next PR incorporating update of OpenAPI generator would have the kubernetes-client/gen#155 as well as kubernetes-client/gen#154

@palnabarun
Copy link
Member Author

Thanks for the approval. 🙂

@booooh booooh mentioned this pull request May 21, 2020
Closed
3 tasks
@Windfarer Windfarer mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw roycaihw approved these changes

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

@palnabarun palnabarun

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@palnabarun @k8s-ci-robot @roycaihw @yliaog