Use a threadpool for async requests

[yuvipanda]

Currently, a new thread is created for each HTTP request. Would be nicer to have the option of using a ThreadPool with a ThreadPoolExecutor instead.

We can already wrap this ourselves when using, but would be nice to do this in the library itself so async usage is cleaner

[dims]

@yuvipanda : we are using urllib3.PoolManager, please see https://github.com/kubernetes-client/python-base/blob/7c8e59b58d9a769f1ca3f818aa91c8a6538b51b1/rest.py#L110

[yuvipanda]

Aaah, whoops! Didn't notice that - it was doing Thread() last time I looked (was a while ago!). Thanks :)

[yuvipanda]

I'm actually curious about https://github.com/kubernetes-incubator/client-python/blob/f399ece006d43970a9d25052798782db1407fd05/kubernetes/client/api_client.py#L331 - which starts an entirely new thread for each request still. This is a thread pool, unrelated to the urllib3 connection pool...

[yuvipanda]

Note: I've started using a threadpool for this in my applications and performance is much better!

[mbohlool]

That is a good idea. Would I suggest you contribute it back to swagger-codegen. Their templates should be straightforward to edit with your changes. When you did, we can import the changes here.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.