-
Notifications
You must be signed in to change notification settings - Fork 3.3k
ConfigExceptions aren't made visible #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The behavior is specific to exec plugin and was introduced in kubernetes-client/python-base#75. Here is some context: kubernetes-client/python-base#75 (comment). The reason was to give a chance to other auth methods. @yliaog Do you have concerns with the proposal? If we change the behavior, we should document it in the release notes in case people are depending on the behavior. |
I think the reason (give a chance to other auth methods) is still valid, what do you think @merval ? |
Yeah, that seems valid. In my case the ConfigException is thrown because the token is expired. I wonder of there should be a mechanism to raise the ConfigException if all other authentication methods fail. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What is the feature and why do you need it:
When loading the kube config, if any ConfigException is thrown it's caught and simply printed as an error message. This prevents any action being taken by the user when the exception is thrown. It also doesn't halt the application, which causes cascading errors.
Describe the solution you'd like to see:
Very simple fix:
python/kubernetes/base/config/kube_config.py
Lines 519 to 520 in e0234d3
Should be:
The text was updated successfully, but these errors were encountered: