Skip to content

Header key 'Authorization' or 'authorization' #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbohlool opened this issue Feb 21, 2017 · 9 comments
Closed

Header key 'Authorization' or 'authorization' #128

mbohlool opened this issue Feb 21, 2017 · 9 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. help-needed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mbohlool
Copy link
Contributor

Throughout the client-python implementation, we consistently used 'authorization' as the header key. urllib3 is also using that, but in some libraries, capital "Authorization" is used. This issue is a placeholder for doing a research on this and make sure we are doing the right thing.

@SEJeff
Copy link
Contributor

SEJeff commented Feb 21, 2017

The correct http header is Authorization with a capital A, however most python client libs use them case insensitive (see: requests, or django's test client as examples). Also, they are case insensitive.

My preference is actually Authorization as I frequently replicate data with curl / requests manually, and that is how most apps send it or webservers respond. However, per those two rfcs, neither are wrong per-se.

@mbohlool
Copy link
Contributor Author

I agree, it should be capital Authorization with case insensitive checks. Will add help needed label so somebody look at this (It could be me if I find the time).

@saurav-malani
Copy link

Hi @mbohlool @SEJeff. If no one is working on this issue, then I would like to work on this issue.

@roycaihw
Copy link
Member

/assign @saurav-malani

@k8s-ci-robot
Copy link
Contributor

@roycaihw: GitHub didn't allow me to assign the following users: saurav-malani.

Note that only kubernetes-client members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @saurav-malani

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roycaihw roycaihw added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 30, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 26, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. help-needed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants