This repository was archived by the owner on Mar 13, 2022. It is now read-only.
added configuration 'http_proxy' to allow the usage of a proxy #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbohlool
force-pushed
the
proxy
branch
2 times, most recently
from
217e40b to
dd68a0a
Compare
pokoli
reviewed
Jun 8, 2017
| **kwargs | ||
| ) | ||
| if config.http_proxy_url is not None: | ||
| self.pool_manager = urllib3.proxy_from_url( |
There was a problem hiding this comment.
Maybe we should add a test that mocks proxy_from_url and we ensure it's called when seting config.http_proxy_url
There was a problem hiding this comment.
I asked the original developer to add test and he didn't have time to do it I guess, I will try to add something. Though I am now short on time and this can take a while.
|
closing in favor of #15 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
porting kubernetes-client/python#206 to python-base repo.