Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Fix exec command parameter expansion #35

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

mbohlool
Copy link
Contributor

Simplify command parameter expansion of websocket_call that will also fix a bug with it (kubernetes-client/python#346 originally tried to fix this before we move websocket code to the base repo). cc @eyeofthefrog

@codecov-io
Copy link

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files          11       11           
  Lines         829      829           
=======================================
  Hits          774      774           
  Misses         55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41c447...67a69d4. Read the comment docs.

@dims
Copy link

dims commented Oct 18, 2017

LGTM 👍 we could add a test case when possible

@mbohlool
Copy link
Contributor Author

Thanks @dims. I spend a little time on writing a test but I needed to mock WebSocket class and I didn't find an easy way to do it. I will merge this without a test for now.

@mbohlool mbohlool merged commit 9213876 into kubernetes-client:master Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants