This repository was archived by the owner on Mar 13, 2022. It is now read-only.
Use a higher value for connecion_pool_maxsize. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. I will let @yuvipanda test and confirm this before merging. Thanks @pokoli. |
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=======================================
Coverage 93.93% 93.93%
=======================================
Files 11 11
Lines 824 824
=======================================
Hits 774 774
Misses 50 50Continue to review full report at Codecov.
|
yuvipanda
approved these changes
Aug 22, 2017
| # per pool. urllib3 uses 1 connection as default value, but this is | ||
| # not the best value when you are making a lot of possibly parallel | ||
| # requests to the same host, which is often the case here. | ||
| # cpu_count * 5 is used as default value to increase performance |
There was a problem hiding this comment.
Add a note saying we're doing this because this is the default for ThreadPoolExecutor?
|
Thanks for the review guys! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26