This repository was archived by the owner on Mar 13, 2022. It is now read-only.
fix: field extra_args recursive growth caused by Resource and Subreso… #251
+31
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
size/S
|
/assign @fabianvf |
|
/approve |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
please squash the commits |
…urce to_dict method when cache with CacheDecoder
jamesgetx
force-pushed
the
fix_to_dict
branch
from
fabcbae to
bd944a5
Compare
Done |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianvf, jamesgetx, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yliaog it looks like your hold is still active, was there more you wanted or is it good to unhold? |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
removed hold, looks good after squashing commits |
|
/release-note-none |
k8s-ci-robot
added
release-note-none
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Field
extra_argsgrow recursively caused by theto_dictmethod ofResourceandSubresourcewhen decode withCacheDecoder. The cache file fragment is shown below.the pr also fix another problem which
Resourcelost valid attributesingularNameandshortNameswhenCacheDecoderdecode from cache file.