-
Notifications
You must be signed in to change notification settings - Fork 182
dynamic client: restore discovery client exception handling #215
dynamic client: restore discovery client exception handling #215
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 13 13
Lines 1635 1635
=======================================
Hits 1509 1509
Misses 126 126 Continue to review full report at Codecov.
|
f5cdcd4
to
39b7849
Compare
/cc @fabianvf The test still fails. I cannot tell if this behavior change was intended. @fabianvf Do you remember?
|
@roycaihw not sure why I would have dropped that exception, probably was an issue pulling the PR from the openshift repo |
39b7849
to
acdd058
Compare
/lgtm |
@fabianvf Got it, thanks. I restored the exception and now the test passes |
fixes the flake in kubernetes-client/python#1281.
With #187, the meta_request now raises
NotFoundError
instead ofResourceNotFoundError
if discovery doc is not ready.