watch stream: don't unmarshal responses when streaming log

[roycaihw]

We were doing a best-effort unmarshalling for both pod log and regular watches, but we really shouldn't try unmarshalling pod logs into watch events. The existing code would unmarshal a pod log that happens to be a JSON blob and contains a field "object".

/hold
We need an e2e test for basic watch functionality in the main repo first.

/cc @Ark-kun @palnabarun

[k8s-ci-robot]

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: Ark-kun.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

We were doing a best-effort unmarshalling for both pod log and regular watches, but we really shouldn't try unmarshalling pod logs into watch events. The existing code would unmarshal a pod log that happens to be a JSON blob and contains a field "object".

/hold
We need an e2e test for basic watch functionality in the main repo first.

/cc @Ark-kun @palnabarun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-io]

Codecov Report

Merging #185 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   92.46%   92.52%   +0.05%     
==========================================
  Files          13       13              
  Lines        1487     1485       -2     
==========================================
- Hits         1375     1374       -1     
+ Misses        112      111       -1

Impacted Files	Coverage Δ
watch/watch.py	100% <100%> (+1.17%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e7976b...ea11e44. Read the comment docs.

[roycaihw]

adding a test in main repo: kubernetes-client/python#1087

[roycaihw]

kubernetes/e2e_test/test_watch.py::TestClient::test_watch_configmaps Running test against : https://10.20.255.31:8443
PASSED

/hold cancel

This change is ready for review. Please take a look

[palnabarun]

Thank you for walking me through the changes and the background personally. :)

/lgtm