Update pycodestyle #115
Update pycodestyle #115
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/lgtm we need to add pycodestyle check in the repo if we haven't done so, to avoid failing the check when we update the submodule in main repo |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamneha, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| Implementation of the proposal for out-of-tree client | ||
| authentication providers as described here -- | ||
| https://github.com/kubernetes/community/blob/master/contributors | ||
| /design-proposals/auth/kubectl-exec-plugins.md |
There was a problem hiding this comment.
I'm a bit worried about breaking the link into two lines.
There was a problem hiding this comment.
@micw523 you're right. the failure in main repo was red herring. we can revert the change here and restore one-line link
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 91.94% 91.94%
=======================================
Files 13 13
Lines 1217 1217
=======================================
Hits 1119 1119
Misses 98 98
Continue to review full report at Codecov.
|
|
@roycaihw The CI pulls the python repo during the process and updates the submodule with the PR contents. We do check pycodestyle for the sub repo. |
No description provided.